Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: give user-friendly permalinks in changelog #2315

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

rickeylev
Copy link
Collaborator

The changelog header text doesn't turn into nice linkable ids. e.g. the "0.37.0" header
is simply "id1" (and similar for all the other headers).

To fix, use block attributes (made possible by the MyST attrs_block extension) to give them
ids manually. The ids start with "v" and use dashes because a dotted number isn't
accepted as a valid id.

It was a bit tedious to update all the headers with ids, so I only did it for the last few
releases.

@rickeylev rickeylev requested a review from aignas as a code owner October 19, 2024 19:18
@rickeylev rickeylev enabled auto-merge October 19, 2024 19:18
@rickeylev rickeylev requested a review from groodt October 19, 2024 19:18
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickeylev rickeylev added this pull request to the merge queue Oct 20, 2024
Merged via the queue into bazelbuild:main with commit 15345b8 Oct 20, 2024
4 checks passed
@rickeylev rickeylev deleted the fix.changelog.headerlink branch October 29, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants